diff --git a/src/main/java/net/kapcake/bankingservice/controllers/BankingServiceController.java b/src/main/java/net/kapcake/bankingservice/controllers/BankingServiceController.java index fc5aa30..800baeb 100644 --- a/src/main/java/net/kapcake/bankingservice/controllers/BankingServiceController.java +++ b/src/main/java/net/kapcake/bankingservice/controllers/BankingServiceController.java @@ -2,8 +2,8 @@ package net.kapcake.bankingservice.controllers; import jakarta.validation.Valid; import net.kapcake.bankingservice.exceptions.ValidationException; -import net.kapcake.bankingservice.model.dtos.PaymentDTO; import net.kapcake.bankingservice.model.dtos.BankAccountDTO; +import net.kapcake.bankingservice.model.dtos.PaymentDTO; import net.kapcake.bankingservice.model.dtos.PaymentFilter; import net.kapcake.bankingservice.security.UserDetailsImpl; import net.kapcake.bankingservice.services.AccountService; @@ -11,12 +11,12 @@ import net.kapcake.bankingservice.services.PaymentService; import org.springframework.http.HttpStatus; import org.springframework.security.core.annotation.AuthenticationPrincipal; import org.springframework.validation.BindingResult; -import org.springframework.validation.FieldError; -import org.springframework.validation.ObjectError; import org.springframework.web.bind.annotation.*; import java.util.List; +import static net.kapcake.bankingservice.controllers.ControllerUtils.getErrorString; + @RestController public class BankingServiceController { private final AccountService accountService; @@ -56,20 +56,5 @@ public class BankingServiceController { paymentService.deletePayment(authenticatedUser, id); } - private static String getErrorString(BindingResult bindingResult) { - StringBuilder builder = new StringBuilder("["); - List allErrors = bindingResult.getAllErrors(); - for (int i = 0; i < allErrors.size(); i++){ - ObjectError error = allErrors.get(i); - if (i != 0) { - builder.append("\n"); - } - if (error instanceof FieldError) { - builder.append(((FieldError) error).getField()); - } - builder.append(": ").append(error.getDefaultMessage()); - } - builder.append("]"); - return builder.toString(); - } + } diff --git a/src/main/java/net/kapcake/bankingservice/controllers/ControllerUtils.java b/src/main/java/net/kapcake/bankingservice/controllers/ControllerUtils.java new file mode 100644 index 0000000..6232551 --- /dev/null +++ b/src/main/java/net/kapcake/bankingservice/controllers/ControllerUtils.java @@ -0,0 +1,27 @@ +package net.kapcake.bankingservice.controllers; + +import org.springframework.validation.BindingResult; +import org.springframework.validation.FieldError; +import org.springframework.validation.ObjectError; + +import java.util.List; + +public class ControllerUtils { + public static String getErrorString(BindingResult bindingResult) { + StringBuilder builder = new StringBuilder("["); + List allErrors = bindingResult.getAllErrors(); + for (int i = 0; i < allErrors.size(); i++) { + ObjectError error = allErrors.get(i); + if (i != 0) { + builder.append("\n"); + } + if (error instanceof FieldError) { + builder.append(((FieldError) error).getField()) + .append(": "); + } + builder.append(error.getDefaultMessage()); + } + builder.append("]"); + return builder.toString(); + } +}