kapcake/banking-service
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Activity

Extract validation error message paring to util class

Browse Source
This commit is contained in:
kapcake
2023-05-14 00:40:45 +02:00
parent 3d1c1b605f
commit 8383fa5055
2 changed files with 31 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
src/main/java/net/kapcake/bankingservice/controllers/BankingServiceController.java
View File

@@ -2,8 +2,8 @@ package net.kapcake.bankingservice.controllers;
import jakarta.validation.Valid; import jakarta.validation.Valid;
import net.kapcake.bankingservice.exceptions.ValidationException; import net.kapcake.bankingservice.exceptions.ValidationException;
import net.kapcake.bankingservice.model.dtos.PaymentDTO;
import net.kapcake.bankingservice.model.dtos.BankAccountDTO; import net.kapcake.bankingservice.model.dtos.BankAccountDTO;
import net.kapcake.bankingservice.model.dtos.PaymentDTO;
import net.kapcake.bankingservice.model.dtos.PaymentFilter; import net.kapcake.bankingservice.model.dtos.PaymentFilter;
import net.kapcake.bankingservice.security.UserDetailsImpl; import net.kapcake.bankingservice.security.UserDetailsImpl;
import net.kapcake.bankingservice.services.AccountService; import net.kapcake.bankingservice.services.AccountService;
@@ -11,12 +11,12 @@ import net.kapcake.bankingservice.services.PaymentService;
import org.springframework.http.HttpStatus; import org.springframework.http.HttpStatus;
import org.springframework.security.core.annotation.AuthenticationPrincipal; import org.springframework.security.core.annotation.AuthenticationPrincipal;
import org.springframework.validation.BindingResult; import org.springframework.validation.BindingResult;
import org.springframework.validation.FieldError;
import org.springframework.validation.ObjectError;
import org.springframework.web.bind.annotation.*; import org.springframework.web.bind.annotation.*;
import java.util.List; import java.util.List;
import static net.kapcake.bankingservice.controllers.ControllerUtils.getErrorString;
@RestController @RestController
public class BankingServiceController { public class BankingServiceController {
private final AccountService accountService; private final AccountService accountService;
@@ -56,20 +56,5 @@ public class BankingServiceController {
paymentService.deletePayment(authenticatedUser, id); paymentService.deletePayment(authenticatedUser, id);
} }
private static String getErrorString(BindingResult bindingResult) {
StringBuilder builder = new StringBuilder("[");
List<ObjectError> allErrors = bindingResult.getAllErrors();
for (int i = 0; i < allErrors.size(); i++){
ObjectError error = allErrors.get(i);
if (i != 0) {
builder.append("\n");
}
if (error instanceof FieldError) {
builder.append(((FieldError) error).getField());
}
builder.append(": ").append(error.getDefaultMessage());
}
builder.append("]");
return builder.toString();
}
} }

27
src/main/java/net/kapcake/bankingservice/controllers/ControllerUtils.java Normal file
View File

@@ -0,0 +1,27 @@
package net.kapcake.bankingservice.controllers;
import org.springframework.validation.BindingResult;
import org.springframework.validation.FieldError;
import org.springframework.validation.ObjectError;
import java.util.List;
public class ControllerUtils {
public static String getErrorString(BindingResult bindingResult) {
StringBuilder builder = new StringBuilder("[");
List<ObjectError> allErrors = bindingResult.getAllErrors();
for (int i = 0; i < allErrors.size(); i++) {
ObjectError error = allErrors.get(i);
if (i != 0) {
builder.append("\n");
}
if (error instanceof FieldError) {
builder.append(((FieldError) error).getField())
.append(": ");
}
builder.append(error.getDefaultMessage());
}
builder.append("]");
return builder.toString();
}
}